Skip to content

Conversation

@jnsdls
Copy link
Member

@jnsdls jnsdls commented Oct 20, 2025

TL;DR

Added dynamic = "force-dynamic" to Stripe-related pages to ensure they always fetch fresh data.

What changed?

Added the export const dynamic = "force-dynamic" directive to three Stripe-related pages:

  • cancel-plan/[team_id]/page.tsx
  • checkout/[team_slug]/[sku]/page.tsx
  • manage-billing/[team_slug]/page.tsx

How to test?

  1. Navigate to any of the affected Stripe pages (cancel plan, checkout, manage billing)
  2. Verify that the pages load correctly and display up-to-date billing information
  3. Confirm that the pages don't serve cached content by making changes to billing information and refreshing

Why make this change?

The force-dynamic directive ensures these pages are always server-rendered with fresh data on each request, which is critical for billing-related operations. This prevents caching issues that could lead to displaying outdated billing information or processing payments with stale data.

Summary by CodeRabbit

  • Chores
    • Updated billing pages (cancel plan, checkout, and manage billing) to ensure they always display the latest information.

@changeset-bot
Copy link

changeset-bot bot commented Oct 20, 2025

⚠️ No Changeset found

Latest commit: cda21e0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 20, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
docs-v2 Ready Ready Preview Comment Oct 20, 2025 11:17pm
nebula Ready Ready Preview Comment Oct 20, 2025 11:17pm
thirdweb_playground Ready Ready Preview Comment Oct 20, 2025 11:17pm
thirdweb-www Building Building Preview Comment Oct 20, 2025 11:17pm
wallet-ui Ready Ready Preview Comment Oct 20, 2025 11:17pm

💡 Enable Vercel Agent with $100 free credit for automated AI reviews

@jnsdls jnsdls marked this pull request as ready for review October 20, 2025 23:13
@jnsdls jnsdls requested review from a team as code owners October 20, 2025 23:13
Copy link
Member Author

jnsdls commented Oct 20, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Oct 20, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 20, 2025

Walkthrough

The pull request adds a Next.js dynamic rendering configuration (export const dynamic = "force-dynamic";) to three stripe-related page routes in the dashboard application, enforcing dynamic (non-static) rendering behavior for these pages.

Changes

Cohort / File(s) Summary
Stripe Pages - Force Dynamic Rendering
apps/dashboard/src/app/(app)/(stripe)/cancel-plan/[team_id]/page.tsx, apps/dashboard/src/app/(app)/(stripe)/checkout/[team_slug]/[sku]/page.tsx, apps/dashboard/src/app/(app)/(stripe)/manage-billing/[team_slug]/page.tsx
Added export const dynamic = "force-dynamic"; to enforce dynamic rendering in Next.js. No functional logic changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
Description Check ⚠️ Warning The pull request has no description provided by the author. The required template specifies that PRs should include a properly formatted title, notes for the reviewer, and testing instructions, but the PR description field contains only the commented template placeholder with no actual content. The PR is also marked as a draft, and critical information such as what problem the force-dynamic export solves, why these specific pages need this configuration, and how to verify the changes work correctly are entirely absent. This represents a complete lack of descriptive content that would help reviewers understand the context and motivation for the changes. The author should provide a complete pull request description following the repository template. This should include a properly formatted title matching the "[SDK/Dashboard/Portal] Feature/Fix:" convention, an optional Linear issue tag if applicable, notes for reviewers explaining why forcing dynamic rendering is necessary for these Stripe-related pages, and detailed testing instructions on how to verify the changes function correctly. Even basic information about why this change is needed and what scenarios would cause these pages to be served statically versus dynamically would significantly improve clarity.
✅ Passed checks (1 passed)
Check name Status Explanation
Title Check ✅ Passed The PR title "Add force-dynamic to Stripe-related pages" directly and clearly summarizes the main change across all three modified files. It is concise, specific, and avoids vague language or noise. A teammate reviewing the commit history would immediately understand that this PR adds the force-dynamic rendering directive to Stripe-related pages, making it fully related to the changeset.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch Add_force-dynamic_to_Stripe-related_pages

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Oct 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 54.89%. Comparing base (ceba683) to head (cda21e0).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8288   +/-   ##
=======================================
  Coverage   54.89%   54.89%           
=======================================
  Files         919      919           
  Lines       60623    60623           
  Branches     4116     4116           
=======================================
  Hits        33282    33282           
  Misses      27240    27240           
  Partials      101      101           
Flag Coverage Δ
packages 54.89% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 64.51 KB (0%) 1.3 s (0%) 225 ms (+180.48% 🔺) 1.6 s
thirdweb (cjs) 365.68 KB (0%) 7.4 s (0%) 814 ms (+2.79% 🔺) 8.2 s
thirdweb (minimal + tree-shaking) 5.73 KB (0%) 115 ms (0%) 74 ms (+1917.64% 🔺) 188 ms
thirdweb/chains (tree-shaking) 526 B (0%) 11 ms (0%) 75 ms (+3570.8% 🔺) 85 ms
thirdweb/react (minimal + tree-shaking) 19.13 KB (0%) 383 ms (0%) 86 ms (+1209.17% 🔺) 469 ms

@jnsdls jnsdls merged commit f00f559 into main Oct 20, 2025
25 of 26 checks passed
@jnsdls jnsdls deleted the Add_force-dynamic_to_Stripe-related_pages branch October 20, 2025 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants